Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat the forwarder user as a separate parameter #371

Closed
wants to merge 4 commits into from
Closed

Treat the forwarder user as a separate parameter #371

wants to merge 4 commits into from

Conversation

Tamerz
Copy link
Contributor

@Tamerz Tamerz commented Apr 1, 2024

Pull Request (PR) description

Now the forwarder uses a completely different user name. I thought using a new splunk::params::splunk_forwarder_user would make things cleaner.

It also sets the forwarder user to the correct default user for Windows.

This Pull Request (PR) fixes the following issues

Fixes #369

kenyon
kenyon reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting params.pp to hiera data would simplify this, but that's a separate task. LGTM once REFERENCE.md is updated so that the tests can run. bundle exec rake strings:generate:reference

Also, please rebase on master to remove the merge commit. Thanks.

@Tamerz Tamerz closed this by deleting the head repository Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon left review comments

Assignees
No one assigned
Labels
tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Splunk Forwarder user on Windows
2 participants
@Tamerz @kenyon